-
Notifications
You must be signed in to change notification settings - Fork 102
test(user-card): add a11y and visual tests #2169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: beta
Are you sure you want to change the base?
test(user-card): add a11y and visual tests #2169
Conversation
|
✅ Deploy Preview for stacks-svelte ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for stacks ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…tps://github.com/StackExchange/Stacks into spark-160/add-a11y-and-visual-tests-to-user-card
|
Hey Tavian, just wanted to ask if these tests were AI written? I will spend a bit extra energy reviewing the tests if that's the case. |
Partially, I had AI create them and then went through each and made some changes |
|
Thanks for the clarification Tavian, that helps 🙏🏾 I noticed the following visual tests looked a bit odd. Could you confirm these are correct?
|
I'll fix those now |
mukunku
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, Tavian. Everything looks good to me now!


SPARK-160
Added a11y and visual tests for the User Card component
After running the a11y tests, there are accessibility errors in additional bling due to the title not being sufficient for screen readers, so I've updated the component to add the aria-label